feat: handle failures in task wait #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NonlinearFruit <1123benji5813@gmail.com>
|
|
Contributor
Author
|
@APErebus, if you get a chance, could you possibly look into this? If you have any questions / concerns, I'd love to help address them. Thank you! |
Contributor
Sure! Will look at it today :) |
Contributor
Thanks for the review @domenicsim1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checks for
FinishedSuccessfully, and returns an error for non-successful tasks. The error message used comes from the C# implementation ("One or more deployment tasks failed.").Fixes #390.
Notes
By adding more tests to
task wait, the test runtime has increased quite a bit due totime.Sleep(5 * time.Second). I would like some input on this. I could potentially replace it with a mock timer to speed things back up. The overhead of adding more tests totask waitis pretty significant currently 😅