Skip to content

Conversation

@emawby
Copy link
Contributor

@emawby emawby commented Jan 10, 2023

Description

One Line Summary

This PR fixes the OneSignal.podspec to allow it to be published.

Details

The dependency for the OSCore subspec was pointing to the OneSignalXCFramework/OneSignalCore instead of OneSignal/OneSignalCore

Motivation

required for releasing the OneSignal.podspec (we may want to drop this though)

Scope

release

Manual testing

This fix enabled the release of alpha 01

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the base branch from main to major_release_5.0.0 January 10, 2023 19:12
@emawby emawby merged commit d11adc2 into major_release_5.0.0 Jan 12, 2023
@emawby emawby deleted the fix/Onesignal_podspec branch January 12, 2023 21:32
nan-li pushed a commit that referenced this pull request Oct 30, 2023
nan-li pushed a commit that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants