Skip to content

Media attachments service extension #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2017
Merged

Media attachments service extension #198

merged 5 commits into from
Mar 9, 2017

Conversation

@jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Mar 9, 2017 •
edited by jwilm
Loading

  • Notification Service Extension is now used instead of content-available on iOS 10 for Action buttons and Media attachments.
  • This improves the reliably of and delivery speed of notifications with these features enabled.
  • Added the following selectors that must be used with from your Notification Service Extension.
    • didReceiveNotificatioExtensionnRequest:withMutableNotificationContent:
    • serviceExtensionTimeWillExpireRequest:withMutableNotificationContent:
  • Fixed bug where actionID was not being set since release 2.3.6.
  • Cleaned up Objective-c example project
  • Added additional unit test and fixed flaky tests with Travis-CI
  • Fixed crash with action buttons when using the new os_data payload.

This change is Reviewable

jkasten2 added 5 commits March 7, 2017 19:26
@jkasten2
Now supports using a notification service extension for attachments
5b3260d 
* Action buttons support is included as well.
* Updated example
* Fixed flaky travis tests due to a slow execution of tests.
@jkasten2
Fixed crash with new os_data payload type and buttons
7bc0584 
* Crash would only happen if the new os_data type payload was received by the device along with a receiver being setup and no title or subtitle set.
@jkasten2
Fixes and tests for new 2.4.0 button format on open event
a2c2f79
@jkasten2
Added service extension termination handling and payload format handling
6fd4c1f 
* Added serviceExtensionTimeWillExpireRequest handler so buttons still show if other customizations take to look to process.
* Fixed handling of new payload with buttons.
* Corrected mock notification to be a remote type.
@jkasten2
Added UIKit requirement for extension and other misc
86f3fc2 
* Cleaned up OneSignal.h
* Cleaned up Objective-C example project.
@jkasten2 jkasten2 merged commit a1bef2c into master Mar 9, 2017
@jkasten2 jkasten2 deleted the media_attachments_service_extension branch March 10, 2017 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jkasten2