Fix leak #326
Merged
Fix leak #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of having to manually build an HTTP request every time the app needs to make a request with the backend, this commit simplifies the process by encapsulating all of this code in a few classes. * Also fixes an issue with registerUser where location data was not being sent. The location data was being added to 'dataDic' after it got serialized into JSON data
* Forgot to import appropriate headers breaking a test.
* Closed the url_session branch since it is now obsolete
* Due to the fact that we've switched to a new rest model, the old enqueueRequest:onSuccess... method is no longer needed and has been removed from the project * Also removed the overrider for this method from unit test shadows
* Fixes some typos * Accesses OneSignalClient sharedClient using a property accessor instead of a method getter for cleaner syntax * Moves JSON parser method to OneSignalClient class for logical consistency * Removes unnecessary log statements
* Fixes an issue iOS 7, buttons were not being shown on the UIAlertView when the app was in focus. * Also fixes an issue where the button action ID wasn't being forwarded to the host application (via OSHandleNotificationActionBlock)
* Minor commit to remove the OneSignalHTTPClient from the project since it is no longer used.
* Resolves a memory leak introduced by creating NSURLSession instances and not calling [session finishTasksAndInvalidate]. The effect of this leak was relatively small since it only leaks 600 bytes per request, but it does add up over time.
* Switched OneSignalClient to use a single shared instance of NSURLSession instead of creating a new instance for every HTTP request. * For the Extension image download function, added a function call in OneSignalHelper.m so that the NSURLSession instance is not leaked.
• Fixed an issue in this branch where the Get iOS Params request was displaying a 'missing App ID' error in the debug console. • Added logging for verbose mode showing HTTP requests & parameters • Made it so that requests that require an app ID yet are given a nil/empty app ID will return an NSError and log an error to the console.
• Fixed a small memory leak in OneSignalLocation • malloc() was being used to initialize a temporary location but free() was never called on it so it never got released • Also, added a required CLLocationManager delegate method to prevent a crash in the event of a location manager error
Member
|
Reviewed 13 of 13 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixes a small leak in OneSignalLocation
This change is