Nullability Issue #340
Merged
Nullability Issue #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Since Nullability specifiers have been added to new methods (Email methods) in the SDK, Xcode will show compiler warnings since not all previous methods in OneSignal.h have these specifiers • Since adding nullability flags to existing methods would be a breaking change we will not do this until the next major release. • Until then, this commit adds a compiler flag to ignore nullability warnings.
Member
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Since Nullability specifiers have been added to new methods (Email methods) in the SDK, Xcode will show compiler warnings since not all previous methods in OneSignal.h have these specifiers
• Since adding nullability flags to existing methods would be a breaking change we will not do this until the next major release.
• Until then, this commit adds a compiler flag to ignore nullability warnings.
This change is