Fixed occasional crash when starting app #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash was hard to reproduce but regular enough to be unacceptable.
Nightsd01
added a commit
that referenced
this pull request
Feb 21, 2018
• Fixes a crash highlighted in #343 where nil userId is inserted into dictionary • Changed to better syntax instead of a category on NSNull
Nightsd01
added a commit
that referenced
this pull request
Mar 1, 2018
* Observer Crash • Fixes an issue where, in rare cases, users who call OneSignal.removeSubscriptionObserver() inside of the onOSSubscriptionChanged() delegate method would cause a crash because the observers array gets mutated while it is being enumerated. • This should have been a relatively rare crash since the delegate selector gets offloaded to the main thread which generally would introduce enough of a delay to prevent the crash. * Fix Null Crash • Fixes a crash highlighted in #343 where nil userId is inserted into dictionary • Changed to better syntax instead of a category on NSNull * Add Email to Demos • Adds email to both the Swift and Objective-C Demos * Add Missing Files • The previous commit was missing some project class files & launch screen storyboard. * Add Icons to Swift Demo • Adds OneSignal icons to Swift demo * Fix getPermissionSubscriptionState() Bug • getPermissionSubscriptionState() was not properly returning email subscription state, which was a contributing factor in bug #89 in the Unity SDK repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash was hard to reproduce but regular enough to be unacceptable.
This change is