Extension Badge Handling

[Nightsd01]

• Moves badge increment/decrement logic from the OneSignal backend to the application itself
• This is accomplished using an app extension with an 'app group' to allow communication of data between the host app and it's notification extension service
• This allows the app to maintain a consistent badge count
• Also cleaned up some Firebase code and moved common strings to a definitions file
• Changed the SDK so that it will default to group.{bundle_id}.onesignal as the App Group name if one is not provided in Info.plist

---

This change is 

[jkasten2]

Review status: 0 of 12 files reviewed at latest revision, 4 unresolved discussions.

---

iOS_SDK/OneSignalSDK/Source/OneSignalExtensionBadgeHandler.h, line 6 at r1 (raw file):

//
//  Created by Brad Hesse on 3/15/18.
//  Copyright © 2018 Hiptic. All rights reserved.

Fix copyright header

---

iOS_SDK/OneSignalSDK/Source/OneSignalExtensionBadgeHandler.m, line 6 at r2 (raw file):

//
//  Created by Brad Hesse on 3/15/18.
//  Copyright © 2018 Hiptic. All rights reserved.

Fix copyright header

---

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m, line 1835 at r2 (raw file):

            @"att": @{ @"id": @"http://domain.com/file.jpg" }
        },
        @"badge_inc" : @3

badge_inc should be under os_data or custom depending on the payload type. Otherwise this is going to end up in additional data when os_data is the format type.

---

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m, line 1854 at r2 (raw file):

    XCTAssert([(NSNumber *)[defaults objectForKey:ONESIGNAL_BADGE_KEY] isEqualToNumber:@2]);
}

Can we add an 2nd notification service extension service that the NSDefault is se when aps badge is set but badge_inc is not present?

---

Comments from Reviewable

[Nightsd01]

iOS_SDK/OneSignalSDK/Source/OneSignalExtensionBadgeHandler.h, line 6 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Fix copyright header

Fixed in multiple files.

---

Comments from Reviewable

[Nightsd01]

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m, line 1854 at r2 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Can we add an 2nd notification service extension service that the NSDefault is se when aps badge is set but badge_inc is not present?

Moved the new badge tests to BadgeTests.m, added this as a test

---

Comments from Reviewable

[jkasten2]

Reviewed 3 of 9 files at r1, 17 of 17 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[jkasten2]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable