Fix URLs #356
Merged
Fix URLs #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Sending an image URL with query parameters used to not work. • The SDK was checking the end of URL's to make sure they were an image or other media type (ie. making sure it ended in .jpeg, .mp3, etc) • Changed the SDK so that it will now remove query parameters from the end of URL's before attempting to type check the file extension
Member
|
Can we add a test for this? Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
• Adds a test to make sure the SDK appropriately handles media URL's even if they have query parameters
Member
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Sending an image URL with query parameters used to not work.
• The SDK was checking the end of URL's to make sure they were an image or other media type (ie. making sure it ended in .jpeg, .mp3, etc)
• Changed the SDK so that it will now remove query parameters from the end of URL's before attempting to type check the file extension
This change is