-
Notifications
You must be signed in to change notification settings - Fork 267
Issue Template #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Template #360
Conversation
• Adds an issue template to the SDK
• Adds a link to OneSignal's readme.io docs on common iOS issues
issue_template.md
Outdated
| <!-- | ||
| Example: | ||
|
|
||
| 1. Visit https://site.com/page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be something like open app instead of visit site...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course 🤦♂️ Fixed it
• Added a contributing guidelines document
• Improves the readme, adds a GIF showing a push notification
• Improve quality of the gif
• Further tuned gif for quality vs. filesize
|
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion. issue_template.md, line 5 at r3 (raw file):
Could we add a link to the Contributing guide as well here? README.md, line 11 at r3 (raw file):
Let's check in the images / gifs we add. We can create a new images folder or put it under the example folder perhaps Comments from Reviewable |
Added a link to our contributing guidelines • This link doesn't work currently because it hasn't been merged to master, but when that happens, the contributing link will work.
• Increases the size of the gif
|
README.md, line 11 at r3 (raw file): Previously, jkasten2 (Josh Kasten) wrote…
Since Github uploads these images to their own githubusercontent, even if they come from external URL's, it seems like we don't need to put it in the repo. However we agreed we will upload it to onesignal.com Comments from Reviewable |
• Updates the supported iOS version number
|
Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions. README.md, line 11 at r3 (raw file): Previously, Nightsd01 (Brad Hesse) wrote…
Created a public OneSignal URL. Looks good to me after we update this. Should do a squash locally or through Github to cleans up all the small commits though. Comments from Reviewable |
|
@Nightsd01 Looks good to me after we update the gif URL. We should do a squash locally or through Github to cleans up all the small commits though |
• Change the URL of the GIF now that it has been uploaded to OneSignal's CDN
• Adds an issue template to the SDK
This change is