Skip to content

Conversation

@Nightsd01
Copy link
Contributor

@Nightsd01 Nightsd01 commented Apr 16, 2018

• Adds an issue template to the SDK


This change is Reviewable

• Adds an issue template to the SDK
@Nightsd01 Nightsd01 requested a review from jkasten2 April 16, 2018 18:01
• Adds a link to OneSignal's readme.io docs on common iOS issues
<!--
Example:

1. Visit https://site.com/page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be something like open app instead of visit site...

Copy link
Contributor Author

@Nightsd01 Nightsd01 Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course 🤦‍♂️ Fixed it

• Added a contributing guidelines document
• Improves the readme, adds a GIF showing a push notification
• Improve quality of the gif
• Further tuned gif for quality vs. filesize
@jkasten2
Copy link
Member

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


issue_template.md, line 5 at r3 (raw file):

 2. SEARCH EXISTING ISSUES FOR AN ANSWER: https://goo.gl/WiaCcG
 3. See our Common Issues documentation: https://goo.gl/68ntg2
-->

Could we add a link to the Contributing guide as well here?


README.md, line 11 at r3 (raw file):

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native iOS app with OneSignal.

![alt text](https://s3.amazonaws.com/capioios/images/videoGif7.gif)

Let's check in the images / gifs we add. We can create a new images folder or put it under the example folder perhaps


Comments from Reviewable

Nightsd01 and others added 10 commits April 19, 2018 12:37
Added a link to our contributing guidelines

• This link doesn't work currently because it hasn't been merged to master, but when that happens, the contributing link will work.
• Increases the size of the gif
@Nightsd01
Copy link
Contributor Author

README.md, line 11 at r3 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Let's check in the images / gifs we add. We can create a new images folder or put it under the example folder perhaps

Since Github uploads these images to their own githubusercontent, even if they come from external URL's, it seems like we don't need to put it in the repo. However we agreed we will upload it to onesignal.com


Comments from Reviewable

• Updates the supported iOS version number
@jkasten2
Copy link
Member

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.


README.md, line 11 at r3 (raw file):

Previously, Nightsd01 (Brad Hesse) wrote…

Since Github uploads these images to their own githubusercontent, even if they come from external URL's, it seems like we don't need to put it in the repo. However we agreed we will upload it to onesignal.com

Created a public OneSignal URL. Looks good to me after we update this. Should do a squash locally or through Github to cleans up all the small commits though.


Comments from Reviewable

@jkasten2
Copy link
Member

@Nightsd01 Looks good to me after we update the gif URL. We should do a squash locally or through Github to cleans up all the small commits though

• Change the URL of the GIF now that it has been uploaded to OneSignal's CDN
@Nightsd01 Nightsd01 merged commit a9275a9 into master Apr 20, 2018
@Nightsd01 Nightsd01 deleted the issue_template branch April 20, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants