Remove logs #422
Merged
Remove logs #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Ran a codebase search for usage of NSLog and switched these log statements to use our own log functionality (with different log levels)
• Recently added a new target (OneSignal-Dynamic-Framework). We had an older target called OneSignal-Dynamic, but it actually produced a static framework. • This commit changes the name OneSignal-Dynamic to OneSignal-Static-Framework to be more accurate/descriptive
jkasten2
reviewed
Sep 25, 2018
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
The code changes look good to me.
Do you know if anything could be depending on the name OneSignal-Dynamic today that this rename to OneSignal-Static-Framework could break?
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @jkasten2)
jkasten2
reviewed
Sep 25, 2018
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
• Changed name of a target which the travis script relied on • Removed the command entirely since it should not even be necessary
jkasten2
approved these changes
Sep 25, 2018
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• This minor PR removes a few cases of directly using
NSLoginstead of using our own log function.• Also changes the name of a target in our SDK project from
OneSignal-DynamictoOneSignal-Static-Framework, since it doesn't produce a dynamic framework.This change is