Generate Framework Symlinks #436
Merged
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• We recently switched to using aggregate targets with build scripts to build our universal frameworks. However the script simply put all framework resources (the binary, headers folder, etc) into the root of the framework • Apple recommends that frameworks are structured using symlinks instead, with all actual framework content residing in /Versions/A and using symlinks to the root & /Versions/Current • This commit adds commands to the buildscript to generate these symlinks for both dynamic & static frameworks
jkasten2
approved these changes
Oct 16, 2018
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• We recently switched to using aggregate targets with build scripts to build our universal frameworks. However the script simply put all framework resources (the binary, headers folder, etc) into the root of the framework
• Apple recommends that frameworks are structured using symlinks instead, with all actual framework content residing in /Versions/A and using symlinks to the root & /Versions/Current
• This PR adds commands to the buildscript to generate these symlinks for both dynamic & static frameworks
This change is