Setting External ID's #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Adds setExternalUserId() and removeExternalUserId() as public functions to the OneSignal SDK • Adds tests to verify the request is working correctly and the API request is correctly formatted • Adds a test to verify that removeExternalUserId() works the same except it sends an empty string (which is what the API wants)
• We have a (very) simple dev project for the SDK. This commit adds a text field and button to set an arbitrary external User ID, as well as a button to remove the ID
jkasten2
approved these changes
Dec 4, 2018
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
• Persists the most recently set external user ID so that if a developer sets it every time a user opens the app (setting the same ID every time), the SDK does not send unnecessary duplicate API requests • Adds tests to verify that unnecessary API requests don't occur in this scenario
• I had implemented external user ID for Push players but it turns out we want to support it for Email user records as well. • This commit adds external_user_id to email user records, in a similar matter to how we execute simultaneous requests for sendTags and so on. • Added an integration test in EmailTests to make sure external ID methods work correctly, duplicate requests don't generate unnecessary API traffic, etc. • Changes the OneSignalClientOverrider so that it maintains an array of executed OneSignalRequest (API request) objects. This makes testing more flexible
jkasten2
approved these changes
Dec 6, 2018
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Adds setExternalUserId() and removeExternalUserId() as public functions to the OneSignal SDK
• Adds tests to verify the request is working correctly and the API request is correctly formatted
• Adds a test to verify that removeExternalUserId() works the same except it sends an empty string (which is what the API wants)
This change is