Fix iam preview constraint crash #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #539, constraint conflict in specific scenario with In-App Message fixed by removing all constraints on setup * Changed some DEBUG onesignal logs to VERBOSE
* Fixed IAM not showing on notification click by not nulling thew window on dismissal * Fixed the IAM crash by adding a didPageRenderingComplete flag to track when an IAM is actually showing on the screen with constraints * This fixed problems related to dismissing IAMs with null constraints and bypassing straight tot he delegate dismissal callback * Added impression request into async task to not lock the UI
jkasten2
requested changes
Sep 29, 2019
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Changes look good. Just few typos in comment an early return clean up.
* Returning early when rendering complete is false and we try to dismiss an IAM * Fixed spelling mistakes in a comments
jkasten2
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is