Fixed iOS params issue related to the second init for wrappers #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* On first init call the app id is null form some wrappers * Now every time init is called we try to download the params if the `didCallDownloadParams` false
mikechoch
requested review from
Jeasmine and
jkasten2
and removed request for
jkasten2
* Wrapper SDKs call init twice, once with a null app id and once with a valid app id - On first init: null app id prevents iOS params and initDone will be set true - On second init: valid app id will allow iOS params to be pulled down and init is done already * Log level is now being set to default VERBOSE in NSE - This is so any logs get recorded for the device even when coming from the NSE - The customer will have control app level for showing OneSignal logs, but NSE will always log out logs * Unit test written for checking that init called twice (once with null app id and once with valid app id) does not effect iOS params request
mikechoch
changed the title
jkasten2
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didCallDownloadParamsfalseCurrent status is waiting on a customer to see if this fix resolves their issues regarding
Confirmed DeliveriesThis change is