Add location prompt handling for IAM clicks #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add location prompt to IAM action * Show location prompt when available * Show multiple prompts when available * Add test for prompt and multiple prompts
Jeasmine
requested review from
jkasten2 and
mikechoch
and removed request for
mikechoch
Jeasmine
force-pushed
the
feature/iam-location-pre-prompt
branch
3 times, most recently
from
53ab3fa to
2c3f9eb
Compare
* Pause IAM display if user prompt displayed * Wait for app to be active for IAM evaluation
Jeasmine
force-pushed
the
feature/iam-location-pre-prompt
branch
from
2c3f9eb to
6f51e04
Compare
jkasten2
reviewed
Mar 18, 2020
iOS_SDK/OneSignalSDK/UnitTests/InAppMessagingIntegrationTests.m
Outdated
Show resolved
Hide resolved
mikechoch
suggested changes
Mar 18, 2020
mikechoch
suggested changes
Mar 18, 2020
iOS_SDK/OneSignalSDK/UnitTests/InAppMessagingIntegrationTests.m
Outdated
Show resolved
Hide resolved
mikechoch
approved these changes
Mar 18, 2020
iOS_SDK/OneSignalSDK/UnitTests/Shadows/OSMessagingControllerOverrider.m
Outdated
Show resolved
Hide resolved
Jeasmine
force-pushed
the
feature/iam-location-pre-prompt
branch
from
83c8e00 to
e920476
Compare
Jeasmine
added a commit
that referenced
this pull request
Mar 18, 2020
* Add location prompt to IAM action * Show location prompt when available * Show multiple prompts when available * Add completionHandler to promptLocation * Add test for prompt and multiple prompts * Pause IAM display if user prompt displayed * Wait for app to be active for IAM evaluation
Jeasmine
added a commit
that referenced
this pull request
Mar 18, 2020
* Add location prompt to IAM action * Show location prompt when available * Show multiple prompts when available * Add completionHandler to promptLocation * Add test for prompt and multiple prompts * Pause IAM display if user prompt displayed * Wait for app to be active for IAM evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is