Skip to content

Fixed if checks related to external user id #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Fixed if checks related to external user id #672

merged 1 commit into from
May 28, 2020

Conversation

@mikechoch
Copy link
Contributor

@mikechoch mikechoch commented May 26, 2020 •
edited by jwilm
Loading

  • Make sure when we are updating email external user id we check both push and email channels separately
  • On completion only update the cached external user id if the success status is true (was only checking contains before)
  • Added various UnitTests that check overwriting several scenarios with push and email external user id

This change is Reviewable

@mikechoch
Fixed if checks related to external user id
5986a96 
* Make sure when we are updating email external user id we check both push and email channels separately
* On completion only update the cached external user id if the success status is true (was only checking contains before)
* Added various UnitTests that check overwriting several scenarios with push and email external user id
@mikechoch mikechoch requested review from Jeasmine, emawby and jkasten2 May 26, 2020 15:27
Jeasmine
Jeasmine approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@Jeasmine Jeasmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechoch mikechoch merged commit c161fdf into master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkasten2 jkasten2 Awaiting requested review from jkasten2

2 more reviewers

@Jeasmine Jeasmine Jeasmine approved these changes

@emawby emawby emawby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikechoch @Jeasmine @emawby