Skip to content

Crash fix - ios8 - CLLocationManager.allowsBackgroundLocationUpdates #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Crash fix - ios8 - CLLocationManager.allowsBackgroundLocationUpdates #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions iOS_SDK/OneSignal/OneSignalLocation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ + (void) internalGetLocation:(bool)prompt {
locationManager = [[clLocationManagerClass alloc] init];
[locationManager setValue:[self sharedInstance] forKey:@"delegate"];

if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 8.0) {
float deviceOSVersion = [[[UIDevice currentDevice] systemVersion] floatValue];
if (deviceOSVersion >= 8.0) {

//Check info plist for request descriptions
//LocationAlways > LocationWhenInUse > No entry (Log error)
Expand All @@ -169,7 +170,9 @@ + (void) internalGetLocation:(bool)prompt {
NSString* alwaysDescription = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"NSLocationAlwaysUsageDescription"];
if(backgroundModes && [backgroundModes containsObject:@"location"] && alwaysDescription) {
[locationManager performSelector:@selector(requestAlwaysAuthorization)];
[locationManager setValue:@YES forKey:@"allowsBackgroundLocationUpdates"];
if (deviceOSVersion >= 9.0) {
[locationManager setValue:@YES forKey:@"allowsBackgroundLocationUpdates"];
}
}

else if([[NSBundle mainBundle] objectForInfoDictionaryKey:@"NSLocationWhenInUseUsageDescription"])
Expand Down