Updating example project for setSubscription to disablePush change #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Sep 24, 2020
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
I thinking about it would be clearer if the UI said "OneSignal Push Enabled" / "OneSignal Push Disabled" instead?
Tested the swift project still seeing "Set Subscription ON" / OFF
Looks like we didn't update
onOSSubscriptionChanged in the ViewController.swift in the example project.
Contributor
Author
fixed! |
jkasten2
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using disablePush instead of setSubscription in example projects
This change is