fix iOS 14 unit tests #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Oct 19, 2020
iOS_SDK/OneSignalSDK/UnitTests/Shadows/UIApplicationOverrider.m
Outdated
Show resolved
Hide resolved
jkasten2
reviewed
Oct 19, 2020
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Confirmed tests pass locally in Xcode 12.0.1 on both an iOS 12.4 and iOS 14.0 simulators.
jkasten2
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP PR for fixing iOS 14 unit tests by adding a dummy test app to the XCProject
This change is