Skip to content

Conversation

@emawby
Copy link
Contributor

@emawby emawby commented Apr 1, 2021

Release 3.4.0

This PR also contains a commit for removing a unit testing header from the OneSignalFramework build headers. This did not cause any issues but should be removed.


This change is Reviewable

@emawby emawby requested review from Jeasmine and jkasten2 April 1, 2021 22:38
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 4 of 4 files at r2, 11 of 11 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine)

@emawby emawby merged commit 3379178 into master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants