Remove innocuous warning and use framework in dev app #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning can fire even when the completion block can still be successfully called. Removing to avoid confusion
jkasten2
reviewed
Apr 8, 2021
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @Jeasmine)
jkasten2
approved these changes
Apr 8, 2021
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Jeasmine)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning about the completion handler being deallocated for willShowInForeground was making it seem broken when it wasn't. I am removing it to avoid confusion.
Additionally this PR changes the dev app from using a static library to a framework to allow debugging the OneSignal SDK when running the dev app.
This change is