Dev app - Bump to 1.4.4 and fix target embedding #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OneSignal framework was being embeded more than once due to the NSE and AppClip also emdeding it.
jkasten2
changed the title
Contributor
adamschlesinger
left a comment
adamschlesinger
left a comment
There was a problem hiding this comment.
This PR looks similar to what I had thrown together in #959. IIRC the dev builds were fixed but on submission we still experienced
ITMS-90562: Invalid Bundle - One or more dynamic libraries that are referenced by your app are not present in the dylib search path.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @emawby and @Jeasmine)
emawby
approved these changes
Aug 5, 2021
jkasten2
commented
Aug 7, 2021
Member
Author
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
I was getting that as well, the changes in this PR got me through the whole process.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Jeasmine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is