Add tag key and value fields to dev app #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
approved these changes
Aug 12, 2021
Member
jkasten2
left a comment
jkasten2
left a comment
There was a problem hiding this comment.
Changes look good. Noticed this doesn't update the AppClip target files. Howe do we want to sync the changes to that target?
Reviewed 1 of 1 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nan-li)
nan-li
approved these changes
Aug 16, 2021
| } | ||
|
|
||
| - (IBAction)sendTagButton:(id)sender { | ||
| - (IBAction)sendTagsButton:(id)sender { |
Contributor
There was a problem hiding this comment.
To confirm: this original sendTagsButton always sent the literal string {"key1": "value1"} for test purposes, and now there's another option to send other key/value pairs?
Contributor
Author
There was a problem hiding this comment.
yep exactly. We have the ability to do this on Android and it will be convenient for non-devs to test with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow testers to add a tag to their user without writing code.
This change is