Test to ensure we register after apns response #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emawby
force-pushed
the
fix/register_user_immediately_after_apns
branch
3 times, most recently
from
8e009f9 to
66b3d4f
Compare
emawby
approved these changes
Sep 3, 2021
Contributor
emawby
left a comment
emawby
left a comment
There was a problem hiding this comment.
looks good! We probably don't want to wait for APNs to register the user but that is a separate issue
* This new test is similar to the existing testNotificationPermissionsAcceptedBeforeAddingOneSiganl_waitsForAPNSTokenBeforePlayerCreate test above it however we are testing to ensure we register even when noitification permisions are note enabled.
jkasten2
force-pushed
the
unittest/add_waits_for_apns_response
branch
from
2360f3a to
2505e60
Compare
Base automatically changed from
fix/register_user_immediately_after_apns
to
main
September 13, 2021 18:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new test is similar to the existing
testNotificationPermissionsAcceptedBeforeAddingOneSiganl_waitsForAPNSTokenBeforePlayerCreatetest above it however we are testing to ensure we register even when notification permissions are not enabled.This change is