[fix] dynamic components not render

Ken Berkeley · Ken Berkeley · commit efebac75fec3 · 2017-09-23T17:26:48.000+08:00
diff --git a/dist/min.js b/dist/min.js
diff --git a/examples/dist/client.24351dd9.js b/examples/dist/client.24351dd9.js
diff --git a/examples/dist/client.7df2d988.js b/examples/dist/client.7df2d988.js
diff --git a/examples/dist/index.html b/examples/dist/index.html
@@ -12,5 +12,5 @@
   
 <script src="//unpkg.com/jquery@2.1.4/dist/jquery.min.js"></script>
 <script src="//unpkg.com/bootstrap@3.3.5/dist/js/bootstrap.min.js"></script>
-<script type="text/javascript" src="client.7df2d988.js"></script></body>
+<script type="text/javascript" src="client.24351dd9.js"></script></body>
 </html>
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "vue2-datatable-component",
   "description": "The best Datatable for Vue.js 2.x which never sucks",
-  "version": "2.1.13",
+  "version": "2.1.14",
   "main": "dist/min.js",
   "module": "src/main.js",
   "author": "Ken Berkeley <kenberkeley@foxmail.com>",
diff --git a/src/HeaderSettings/ColumnGroup.vue b/src/HeaderSettings/ColumnGroup.vue
@@ -22,6 +22,7 @@
 import isColVisible from '../_utils/isColVisible'
 
 export default {
+  name: 'ColumnGroup',
   props: {
     groupName: { type: String, required: true },
     columns: { type: Array, required: true }
diff --git a/src/HeaderSettings/index.vue b/src/HeaderSettings/index.vue
@@ -57,6 +57,7 @@ const hash = s => '' + s.split('').reduce((a, b) => (a = (a << 5) - a + b.charCo
 // the hash algorithm above refers to http://stackoverflow.com/a/15710692/5172890
 
 export default {
+  name: 'HeaderSettings',
   components: { ColumnGroup },
   props: {
     columns: { type: Array, required: true },
diff --git a/src/PageSizeSelect.vue b/src/PageSizeSelect.vue
@@ -9,6 +9,7 @@
 </template>
 <script>
 export default {
+  name: 'PageSizeSelect',
   props: {
     query: { type: Object, required: true },
     pageSizeOptions: { type: Array, required: true }
diff --git a/src/Pagination.vue b/src/Pagination.vue
@@ -22,6 +22,7 @@
 </template>
 <script>
 export default {
+  name: 'Pagination',
   props: {
     total: { type: Number, required: true },
     query: { type: Object, required: true }
diff --git a/src/Table/HeadSort.vue b/src/Table/HeadSort.vue
@@ -8,6 +8,7 @@
  * Sorting arrows within <th>
  */
 export default {
+  name: 'HeadSort',
   props: {
     field: { type: String, required: true },
     query: { type: Object, required: true }
diff --git a/src/Table/MultiSelect.vue b/src/Table/MultiSelect.vue
@@ -7,6 +7,7 @@ import replaceWith from 'replace-with'
  * checkbox for multiple select within the leading <th>/<td>
  */
 export default {
+  name: 'MultiSelect',
   props: {
     selection: { type: Array, required: true },
     row: Object, // available for tbody checkbox
diff --git a/src/Table/TableBody.vue b/src/Table/TableBody.vue
@@ -50,6 +50,7 @@ import props from '../_mixins/props'
 import shouldRenderSelection from '../_mixins/shouldRenderSelection'
 
 export default {
+  name: 'TableBody',
   components: { MultiSelect },
   mixins: [props, shouldRenderSelection],
   computed: {
diff --git a/src/Table/TableFooter.vue b/src/Table/TableFooter.vue
@@ -28,6 +28,7 @@ import props from '../_mixins/props'
 import shouldRenderSelection from '../_mixins/shouldRenderSelection'
 
 export default {
+  name: 'TableFooter',
   mixins: [props, shouldRenderSelection]
 }
 </script>
diff --git a/src/Table/TableFrame.vue b/src/Table/TableFrame.vue
@@ -12,6 +12,7 @@ import props from '../_mixins/props'
 import shouldRenderSelection from '../_mixins/shouldRenderSelection'
 
 export default {
+  name: 'TableFrame',
   mixins: [props, shouldRenderSelection]
 }
 </script>
diff --git a/src/Table/TableHeader.vue b/src/Table/TableHeader.vue
@@ -33,6 +33,7 @@ import props from '../_mixins/props'
 import shouldRenderSelection from '../_mixins/shouldRenderSelection'
 
 export default {
+  name: 'TableHeader',
   components: { HeadSort, MultiSelect },
   mixins: [props, shouldRenderSelection]
 }
diff --git a/src/Table/index.vue b/src/Table/index.vue
@@ -52,6 +52,7 @@ import SCROLLBAR_WIDTH from '../_utils/SCROLLBAR_WIDTH'
 import syncScroll from '../_utils/syncScroll'
 
 export default {
+  name: 'Table',
   mixins: [props],
   components: { TableFrame, TableHeader, TableBody, TableFooter },
   data: () => ({
diff --git a/src/_mixins/props.js b/src/_mixins/props.js
@@ -1,5 +1,3 @@
-let comp // cache the source of dynamic components (thComp / tdComp / nested components)
-
 export default {
   props: {
     columns: { type: Array, required: true },
@@ -19,12 +17,13 @@ export default {
     supportBackup: Boolean // support backup for `HeaderSettings`
   },
   data () {
-    if (!comp) {
-      // only src/index.vue could reach here
-      comp = this.$parent.$options.components
+    let datatableInstance = this
+    while (datatableInstance.$options.name !== 'Datatable') {
+      datatableInstance = datatableInstance.$parent
     }
     return {
-      comp // share the same source of dynamic components
+      // the source of dynamic components (thComp / tdComp / nested components)
+      comp: datatableInstance.$parent.$options.components
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "vue2-datatable-component",`
`3`	`3`	`"description": "The best Datatable for Vue.js 2.x which never sucks",`
`4`		`- "version": "2.1.13",`
	`4`	`+ "version": "2.1.14",`
`5`	`5`	`"main": "dist/min.js",`
`6`	`6`	`"module": "src/main.js",`
`7`	`7`	`"author": "Ken Berkeley <kenberkeley@foxmail.com>",`