Feature/ode 50 create authentication service #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enpopo2101
reviewed
Nov 29, 2019
| // Generate an auth token for the user | ||
| const user = this; | ||
| // eslint-disable-next-line no-underscore-dangle | ||
| const token = jwt.sign({ _id: user._id }, process.env.JWT_KEY); |
Contributor
There was a problem hiding this comment.
phần này anh không cần cho thêm hạn sử dụng của token à anh?
Author
There was a problem hiding this comment.
Do dự án mình login chỉ để lấy thông tin, email người dùng thôi. Và anh muốn người ta không cần phải đăng nhập nhiều. Nên mình không cần expire.
| const UserSchema = new Schema( | ||
| const UserSchema = Schema( | ||
| { | ||
| email: { |
NakSin
approved these changes
Dec 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations