add main menu navigation + action files #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestoncarman
requested changes
Oct 7, 2025
| The file for the SetupCalibration class | ||
| """ | ||
| from titration.devices.library import Keypad | ||
| from titration.ui_state.calibration.calibrate_ph import CalibratePh |
There was a problem hiding this comment.
I think you should either leave this file unchanged or put in your stub.
| @@ -0,0 +1,57 @@ | |||
| """ | |||
There was a problem hiding this comment.
Why is this file different from the stub version? I think you should put in your stub. We can later copy over code from Titration.
| @@ -1,82 +1,237 @@ | |||
| """ | |||
There was a problem hiding this comment.
We did not discuss tests, but we should have a set of tests for this menu.
The previous tests are located here: https://github.com/Open-Acidification/TankControllerPython/blob/main/test/ui_state/main_menu_test.py
Please update the tests and make sure we have working set of tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.