Fix: corrected PyTorch eigenvalue test cases to descending order #528
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moe18
reviewed
Sep 3, 2025
Collaborator
moe18
left a comment
moe18
left a comment
There was a problem hiding this comment.
looks good, would you also be able to update the solution code so it will output the correct solution?
Author
|
I have update the solution code as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527
The problem statement specifies that eigenvalues should be sorted
from highest to lowest. However, the PyTorch test cases were
expecting ascending order, which caused correct solutions to fail.
This PR updates the expected outputs in
tests.jsonto descendingorder so they match the problem description.