Skip to content

Support partial updates in STACAPIJobDatabase.persist (take 2) #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Support partial updates in STACAPIJobDatabase.persist (take 2) #798

wants to merge 3 commits into from

Conversation

@soxofaan
Copy link
Member

@soxofaan soxofaan commented Aug 19, 2025

soxofaan added a commit that referenced this pull request Aug 19, 2025
@soxofaan
DummyStacApi._get_search tweak
09e8fe4 
cherry-picked from #794/#798
@soxofaan
Issue 793: Support partial updates in STACAPIJobDatabase.persist
72a9e38 
related to PR #736
@soxofaan
Issue #793/#794 preserve "item_id" column for now
f01a2a1 
Might still be in use in certain use cases

further eliminate fixture anti-patterns in tests, allowing more parameterization
@soxofaan
WIP
cabe0a4
@soxofaan soxofaan force-pushed the issue793-stac-api-job-db-persist-partial-update2 branch from 53b1dc3 to cabe0a4 Compare August 19, 2025 11:00
@soxofaan soxofaan mentioned this pull request Aug 19, 2025
Closed
soxofaan added a commit that referenced this pull request Aug 20, 2025
@soxofaan
Finetune STACAPIJobDatabase tests
36b6155 
Eliminate some fixture anti-patterns (too much abstraction and decoupling)
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Aug 20, 2025
@soxofaan
Finetune STACAPIJobDatabase tests
481ab0c 
Eliminate some fixture anti-patterns (too much abstraction and decoupling)
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Aug 20, 2025
@soxofaan
Make TestSTACAPIJobDatabase.test_get_by_status_result less fake
94a97c8 
further elimination of unnecessary fixtures
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Aug 20, 2025
@soxofaan
Port more STACAPIJobDatabase test tweaks from #798
6bb1232
soxofaan added a commit that referenced this pull request Aug 20, 2025
@soxofaan
fixup! Port more STACAPIJobDatabase test tweaks from #798
5ed4ac0
@soxofaan
Copy link
Member Author

soxofaan commented Aug 20, 2025

as mentioned in #793 (comment) : let's move the task of merging existing data with updates to the job manager (instead of requiring each job db implementation to do this correctly.
(Requires introduction of a new API JobDatabaseInterface.get_by_indices, but that should not be too hard to implement).

This closes this PR (without merge).
(Note that some test related tweaks were ported to master anyway)

@soxofaan soxofaan closed this Aug 20, 2025
@soxofaan soxofaan deleted the issue793-stac-api-job-db-persist-partial-update2 branch August 20, 2025 10:21
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
DummyStacApi._get_search tweak
dc7c626 
cherry-picked from #794/#798
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
Finetune STACAPIJobDatabase tests
84d8ecc 
Eliminate some fixture anti-patterns (too much abstraction and decoupling)
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
Make TestSTACAPIJobDatabase.test_get_by_status_result less fake
b3f665a 
further elimination of unnecessary fixtures
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
Port more STACAPIJobDatabase test tweaks from #798
55b463f
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
fixup! Port more STACAPIJobDatabase test tweaks from #798
68101fa
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
DummyStacApi._get_search tweak
efbbbd1 
cherry-picked from #794/#798
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
Finetune STACAPIJobDatabase tests
e14cc9d 
Eliminate some fixture anti-patterns (too much abstraction and decoupling)
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
Make TestSTACAPIJobDatabase.test_get_by_status_result less fake
36b3a22 
further elimination of unnecessary fixtures
Based on working on #794 and #798
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
Port more STACAPIJobDatabase test tweaks from #798
d633a85
soxofaan added a commit that referenced this pull request Sep 9, 2025
@soxofaan
fixup! Port more STACAPIJobDatabase test tweaks from #798
531000d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soxofaan