Issue741 movedatabasecode #815
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO; move also the unit tests once settled on rearangement |
|
I'd try to do this exercise in atomic commits/PRs:
that will avoid long-running PR review cycles that block other progress e.g. I just started #824 to only move |
soxofaan
reviewed
Nov 3, 2025
| "duration": _ColumnProperties(dtype="str"), | ||
| "costs": _ColumnProperties(dtype="float64"), | ||
| } | ||
|
|
There was a problem hiding this comment.
The three comments above should be moved along with _COLUMN_REQUIREMENTS
| # Expected columns in the job DB dataframes. | ||
| # TODO: make this part of public API when settled? | ||
| # TODO: move non official statuses to seperate column (not_started, queued_for_start) | ||
| COLUMN_REQUIREMENTS = { |
There was a problem hiding this comment.
I don't think COLUMN_REQUIREMENTS belongs under the _job_database module.
The requirements describe what the job manager expects as columns, so this should stay close to the job manager module (__init__.py at the moment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first proposal to seperate the job database/dataframe logic and the processbasedjobstart