[client] add SignatureType supporting classes (#11) #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinemzs
changed the title
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
savacano28
reviewed
Dec 3, 2024
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
antoinemzs
force-pushed
the
issue/11/signature_types
branch
from
884bd58 to
319d989
Compare
|
@savacano28 hopefully the latest commits resolve your comments 🙏 |
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
savacano28
approved these changes
Dec 4, 2024
RomuDeuxfois
reviewed
Dec 4, 2024
| @@ -1,5 +1,5 @@ | |||
| # -*- coding: utf-8 -*- | |||
| __version__ = "1.9.0" | |||
| __version__ = "1.10.0" | |||
There was a problem hiding this comment.
Why do you have this changes ?
There was a problem hiding this comment.
since we're on the 1.10.0 branch, does it not make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...