-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
kotlin-spring: fix exception thrown in enum.forValue #21622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kotlin-spring: fix exception thrown in enum.forValue #21622
Conversation
|
Hi, Could you add one of the terms mentioned in this documentation before your issue reference so that github can better visualize that a PR exists for your issue? |
btpnlsl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
|
https://github.com/OpenAPITools/openapi-generator/actions/runs/16484736455/job/46716135269?pr=21622 please follow step 3 in the checklist to update the samples when you've time |
|
I haven't set up the dev environment locally yet, but I'll try to find some time for it over the weekend. If anyone else has it set up already and meanwhile could run + push it to this branch so that I don't have to I'd appreciate that 😊 |
|
I was able to run the update for the samples on your branch but I can't push due to permissions: |
a9000c7 to
fec386b
Compare
|
Thank you @btpnlsl for trying - not sure why it doesn't work, I've checked "Allow edits by maintainers". 🤷 Anyways, I managed to run the scripts as well meanwhile (on Windows) and pushed the updated samples. (and rebased on latest master) |

This is a suggested fix for #21621 and fixes the
forValue()method generated for enum classes to throw the correct exception,IllegalArgumentExceptionin case in invalid enum string is given. PreviouslyNoSuchElementExceptionhas been thrown.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@dr4ke616 @jimschubert
fixes #21621