Skip to content

Conversation

@swurzinger
Copy link
Contributor

@swurzinger swurzinger commented Jul 24, 2025

This is a suggested fix for #21621 and fixes the forValue() method generated for enum classes to throw the correct exception, IllegalArgumentException in case in invalid enum string is given. Previously NoSuchElementException has been thrown.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @dr4ke616 @jimschubert

fixes #21621

@Mattias-Sehlstedt
Copy link
Contributor

Hi,

Could you add one of the terms mentioned in this documentation before your issue reference so that github can better visualize that a PR exists for your issue?

It will add the icon highlighed in red in the image below.
469379497-5a1cc10a-790a-41b8-a6ca-d0eb3de131ae

Copy link
Contributor

@btpnlsl btpnlsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@wing328
Copy link
Member

wing328 commented Jul 25, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/16484736455/job/46716135269?pr=21622

please follow step 3 in the checklist to update the samples when you've time

@swurzinger
Copy link
Contributor Author

I haven't set up the dev environment locally yet, but I'll try to find some time for it over the weekend. If anyone else has it set up already and meanwhile could run + push it to this branch so that I don't have to I'd appreciate that 😊

@btpnlsl
Copy link
Contributor

btpnlsl commented Jul 26, 2025

I was able to run the update for the samples on your branch but I can't push due to permissions:
remote: Permission to swurzinger/openapi-generator.git denied to btpnlsl

@swurzinger swurzinger force-pushed the kotlin-spring-enum-forvalue-exception-fix branch from a9000c7 to fec386b Compare July 26, 2025 14:40
@swurzinger
Copy link
Contributor Author

swurzinger commented Jul 26, 2025

Thank you @btpnlsl for trying - not sure why it doesn't work, I've checked "Allow edits by maintainers". 🤷

Anyways, I managed to run the scripts as well meanwhile (on Windows) and pushed the updated samples. (and rebased on latest master)

@wing328 wing328 added this to the 7.15.0 milestone Jul 28, 2025
@wing328 wing328 merged commit 0e97e19 into OpenAPITools:master Jul 28, 2025
47 checks passed
@swurzinger swurzinger deleted the kotlin-spring-enum-forvalue-exception-fix branch July 28, 2025 09:59
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
)

* kotlin-spring: fix exception thrown in enum.forValue

* update samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [kotlin-spring] enum forValue should throw IllegalArgumentException

4 participants