Skip to content
This repository was archived by the owner on Nov 24, 2022. It is now read-only.

Conversation

@bmordue
Copy link

@bmordue bmordue commented Jul 6, 2018

Fixes issue described here: OpenAPITools/openapi-generator#177

@jmini
Copy link
Member

jmini commented Jul 6, 2018

This is a great patch! Thank you a lot for the investigation and the fix.


Can you submit it also against swagger-api/swagger-parser?

We are not really using this fork for now.

@jmini
Copy link
Member

jmini commented Jul 6, 2018

Or if you agree I will present it in the official project after having added a unit test for your use case.

@bmordue
Copy link
Author

bmordue commented Jul 6, 2018

Hi @jmini, I just opened the PR there: swagger-api#753
Please feel free to add a test to that branch, or to pick the commit into your own branch.

@jmini
Copy link
Member

jmini commented Jul 6, 2018

I do not have the right to push anything on your no-info-block-oas3 branch, but I have created 9d0094a on top of https://github.com/bmordue/swagger-parser/commit/4a8e21846720edce0b7246ebc08182669998e242

Can you:

  1. give me push right to your branch (I am not maintainer of the other project)
  2. rebase (fast-forward) your no-info-block-oas3 on top of OpenAPITools/no-info-block-oas3

If you edit this PR, are you able to change the branches to:

@bmordue wants to merge 1 commit into OpenAPITools:2.0-OpenAPITools from bmordue:no-info-block-oas3

Current is:

@bmordue wants to merge 1 commit into OpenAPITools:2.0-OpenAPITools from bmordue:no-info-block

Maybe this will give me write right as maintainer of this project.

@bmordue
Copy link
Author

bmordue commented Jul 6, 2018

@jmini Do we still want this PR open, or shall I close it in favour of this one: swagger-api#753 ?

@jmini
Copy link
Member

jmini commented Jul 6, 2018

Leave it open, we like to have the commits our community is interested in our 2.0-OpenAPITools branch. Just in case we need to release it ourself.

More background: OpenAPITools/openapi-generator#68

@jmini jmini force-pushed the 2.0-OpenAPITools branch 2 times, most recently from cd481a0 to 1af820a Compare July 7, 2018 09:56
@jmini jmini merged commit ca2475a into OpenAPITools:2.0-OpenAPITools Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants