Skip to content
This repository was archived by the owner on Jan 5, 2019. It is now read-only.

Conversation

@gordonbrander
Copy link
Contributor

This lets us get lists of variables per category type, and we can get rid of the openag_brain.var_types file, which too easily gets out of sync with this file.

This lets us get lists of variables per category type, and we can get
rid of the `openag_brain.var_types` file, which too easily gets out of
sync with this file.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 83.128% when pulling 648b7d3 on gordonbrander:one_var_to_rule_them_all into d90113e on OpenAgInitiative:master.

@gordonbrander
Copy link
Contributor Author

This has been tested on Raspberry Pi.

@gordonbrander gordonbrander merged commit 1f9fdf6 into OpenAgricultureFoundation:master Feb 16, 2017
@gordonbrander gordonbrander deleted the one_var_to_rule_them_all branch February 16, 2017 04:03
@LeonChambers
Copy link
Collaborator

This is actually very confusing. There is now a list of "categories" in a categories.py file which applies to modules and their inputs/outputs and a different list of "categories" in var_types.py which applies to the environmental variables. One of these 2 concepts should be renamed.

@gordonbrander
Copy link
Contributor Author

That's a good point. I don't care about the name, just need a method to group var_types without resorting to editing in 2 places.

@LeonChambers
Copy link
Collaborator

Yea, I definitely think this change is for the better if the naming is switched out. Maybe "groups" could work?

@gordonbrander
Copy link
Contributor Author

wfm. Will do a followup PR for openag_python and for openag_brain

@gordonbrander
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants