Skip to content

Conversation

@ryjen
Copy link
Collaborator

@ryjen ryjen commented Feb 12, 2024

MainActivity

  • upgraded the viewpager to google's viewpager2

MainMediaFragment;

  • moved broadcast listener from activity
  • moved delete options menu item from activity

ProjectAdapter:

  • changed to viewpager2 adapter base class
  • moved some item logic from activity

MainActivity
- upgraded the viewpager to google's viewpager2

MainMediaFragment;
- moved broadcast listener from activity
- moved delete options menu item from activity

ProjectAdapter:
- changed to viewpager2 adapter base class
- moved some item logic from activity
@uniqx
Copy link

uniqx commented Feb 13, 2024

I looked through the diff and the code changes look fine. I especially appreciate getting rid of mCurrentFragment 👍
I also did a quick build and clicked through the use-case a little, works great.

@uniqx uniqx merged commit 700d68a into OpenArchive:master Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants