Skip to content

Conversation

@ryjen
Copy link
Collaborator

@ryjen ryjen commented Mar 5, 2024

ia.mp4

ryjen added 2 commits March 4, 2024 16:11
the auth keys are returned by a webservice using email/password

a simple link is provided to create an account
@ryjen ryjen requested review from tladesignz and uniqx March 5, 2024 19:12
@ryjen
Copy link
Collaborator Author

ryjen commented Mar 5, 2024

@tladesignz @uniqx Was there a reason that the 'https://archive.org/services/xauthn' API was not used?

Never heard of that. That wasn't mentioned in their S3 documentation

I grabbed it from their (official?) python library. https://github.com/jjjake/internetarchive

Good find, I guess!

@tladesignz
Copy link

Lovely, all the abstraction. Why use 5 files, when you could use 20?
Guess, I'm starting to become an old fart.

fix bug in IA login use case that did not set credentials

update compose material theme to v3

bump db version and add meta data column for provider extra info
@ryjen ryjen changed the title DO NOT MERGE: a WIP of simpler internet archive #495 a simpler internet archive Mar 11, 2024
ryjen added 7 commits March 25, 2024 13:33
 Conflicts:
	app/src/main/java/net/opendasharchive/openarchive/services/SaveClient.kt
	app/src/main/java/net/opendasharchive/openarchive/services/internetarchive/IaConduit.kt
 Conflicts:
	app/src/main/java/net/opendasharchive/openarchive/features/main/MainMediaFragment.kt
	app/src/main/java/net/opendasharchive/openarchive/services/internetarchive/IaConduit.kt
@ryjen ryjen merged commit 6b490c2 into development Mar 26, 2024
@rapuckett rapuckett deleted the feature/ia-refactor branch May 7, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants