Skip to content

Proofmode Fix #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Proofmode Fix #655

merged 1 commit into from
Mar 25, 2025

Conversation

@prathieshna
Copy link

@prathieshna prathieshna commented Mar 24, 2025

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2025
View reviewed changes
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
val hasPermission = ContextCompat.checkSelfPermission(
requireContext(), Manifest.permission.READ_PHONE_STATE
) == PackageManager.PERMISSION_GRANTED
val hasPermission = ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.READ_PHONE_STATE) == PackageManager.PERMISSION_GRANTED

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
requireContext(), Manifest.permission.READ_PHONE_STATE
) == PackageManager.PERMISSION_GRANTED
val hasPermission = ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.READ_PHONE_STATE) == PackageManager.PERMISSION_GRANTED
&& ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.ACCESS_COARSE_LOCATION) == PackageManager.PERMISSION_GRANTED

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
requireContext(), Manifest.permission.READ_PHONE_STATE
) == PackageManager.PERMISSION_GRANTED
val hasPermission = ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.READ_PHONE_STATE) == PackageManager.PERMISSION_GRANTED
&& ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.ACCESS_COARSE_LOCATION) == PackageManager.PERMISSION_GRANTED

Check warning

Code scanning / detekt

Reports mis-indented code Warning

Unexpected indentation (20) (should be 16)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
requireContext(), Manifest.permission.READ_PHONE_STATE
) == PackageManager.PERMISSION_GRANTED
val hasPermission = ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.READ_PHONE_STATE) == PackageManager.PERMISSION_GRANTED
&& ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.ACCESS_COARSE_LOCATION) == PackageManager.PERMISSION_GRANTED

Check warning

Code scanning / detekt

Checks if condition chaining is wrapped right Warning

Line must not begin with "&&"
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
if (newValue as Boolean) {
PermissionX.init(this)
.permissions(Manifest.permission.READ_PHONE_STATE)
.permissions(Manifest.permission.READ_PHONE_STATE, Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION)

Check warning

Code scanning / detekt

Reports lines with exceeded length Warning

Exceeded max line length (120)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
if (newValue as Boolean) {
PermissionX.init(this)
.permissions(Manifest.permission.READ_PHONE_STATE)
.permissions(Manifest.permission.READ_PHONE_STATE, Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION)

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
if (newValue as Boolean) {
PermissionX.init(this)
.permissions(Manifest.permission.READ_PHONE_STATE)
.permissions(Manifest.permission.READ_PHONE_STATE, Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION)

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
if (newValue as Boolean) {
PermissionX.init(this)
.permissions(Manifest.permission.READ_PHONE_STATE)
.permissions(Manifest.permission.READ_PHONE_STATE, Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION)

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)
...src/main/java/net/opendasharchive/openarchive/features/settings/ProofModeSettingsActivity.kt
if (newValue as Boolean) {
PermissionX.init(this)
.permissions(Manifest.permission.READ_PHONE_STATE)
.permissions(Manifest.permission.READ_PHONE_STATE, Manifest.permission.ACCESS_COARSE_LOCATION, Manifest.permission.ACCESS_FINE_LOCATION)

Check warning

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Missing newline before ")"
Elelan
Elelan approved these changes Mar 25, 2025
View reviewed changes
Copy link

@Elelan Elelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Elelan Elelan merged commit fbfbf85 into next Mar 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elelan Elelan Elelan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prathieshna @Elelan