localization fixes from next branch added to backup branch #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Merge localization updates from the next branch into the backup branch, ensuring UI text is up to date across all supported languages.
- Switched encryption intro text to reference Orbot and updated the link.
- Introduced new
open_orbotandunavailablestring entries in English. - Added and adjusted translations in Turkish, French, Farsi, Spanish, and Arabic.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Updated intro_text_encrypt, added open_orbot and unavailable |
| app/src/main/res/values-tr/strings.xml | Added many new keys and translations, appended unavailable |
| app/src/main/res/values-fr/strings.xml | Added new keys, updated French translations, appended unavailable |
| app/src/main/res/values-fa/strings.xml | Added new keys, updated Farsi translations, appended unavailable |
| app/src/main/res/values-es/strings.xml | Added new keys, updated Spanish translations, appended unavailable |
| app/src/main/res/values-ar/strings.xml | Added new keys, updated Arabic translations, appended unavailable |
app/src/main/res/values/strings.xml
Outdated
| <string name="label_create_login">Create one</string> | ||
| <string name="prompt_no_account">No account?</string> | ||
| <string name="action_continue">Continue</string> | ||
| <string name="open_orbot">Open Orbot</string> |
There was a problem hiding this comment.
The new "open_orbot" string key is missing translations in the localized resource files (values-tr, values-fr, values-fa, values-es, values-ar). Please add corresponding entries to keep all locales in sync.
| <string name="lbl_no_servers">No servers added yet.</string> | ||
| <string name="lbl_no_archived_folders">No archived folders found.</string> | ||
| <string name="error_no_internet">Internet not available</string> | ||
| <string name="unavailable">unavailable</string> |
There was a problem hiding this comment.
[nitpick] The value for "unavailable" is lowercase; consider capitalizing it to "Unavailable" to maintain consistency with other UI strings.
Suggested change
| <string name="unavailable">unavailable</string> | |
| <string name="unavailable">Unavailable</string> |
This commit removes the Snackbar confirmation that appeared when deleting media items. The deletion now happens immediately. Additionally, the following changes were made: - Updated AGP to 8.11.0, Kotlin to 2.2.0, and KSP to 2.2.0-2.0.2. - Updated Gradle wrapper to version 8.14.2. - Ensured `BrowseFoldersFragment` navigates back even if the confirmation dialog is dismissed. - Added an `onDismissAction` to `BaseDialog` to allow custom actions when a dialog is dismissed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // }) | ||
|
|
||
| snackbar.show() | ||
| //snackbar.show() |
Check warning
Code scanning / detekt
Checks if comments have the right spacing Warning
This commit updates the dialog UI by changing the icon color to tertiary. It also adds a "Download Orbot" button to the Tor disabled dialog, which links to the Orbot app on the Google Play Store. Additionally, the version name has been updated to 4.0.0 and the version code to 30011. The commit also includes a fix to ensure the arrow in the MainMediaFragment is shown/hidden correctly when the ContentPickerFragment is dismissed.
| import net.opendasharchive.openarchive.features.core.dialog.DialogStateManager | ||
| import net.opendasharchive.openarchive.features.core.dialog.DialogType | ||
| import net.opendasharchive.openarchive.features.core.dialog.showDialog | ||
| import net.opendasharchive.openarchive.features.core.dialog.showWarningDialog |
Check warning
Code scanning / detekt
Detects unused imports Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.