Skip to content

Conversation

@savacano28
Copy link
Contributor

@savacano28 savacano28 commented Feb 17, 2025

Proposed changes

  • Add agent level result expectation in the targets of atomic testing overview:
    image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Feb 17, 2025
@savacano28 savacano28 force-pushed the issue/1860-ui-agents-expectations branch from 0cb9e3a to 75ca09a Compare February 17, 2025 08:39
@savacano28 savacano28 changed the base branch from master to release/current February 17, 2025 08:47
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Feb 17, 2025
@savacano28 savacano28 marked this pull request as ready for review February 17, 2025 08:48
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 41.53846% with 38 lines in your changes missing coverage. Please review.

Project coverage is 39.18%. Comparing base (46665b7) to head (b5d5f4f).
Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
...main/java/io/openbas/utils/AtomicTestingUtils.java 30.90% 35 Missing and 3 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2462      +/-   ##
=====================================================
- Coverage              39.18%   39.18%   -0.01%     
  Complexity              1900     1900              
=====================================================
  Files                    611      611              
  Lines                  18456    18489      +33     
  Branches                1237     1240       +3     
=====================================================
+ Hits                    7232     7244      +12     
- Misses                 10838    10858      +20     
- Partials                 386      387       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the issue/1860-ui-agents-expectations branch 4 times, most recently from cf48caa to 05e510f Compare February 19, 2025 10:51
@savacano28 savacano28 force-pushed the issue/1860-ui-agents-expectations branch from 6354f83 to 4547b3b Compare February 20, 2025 09:50
@savacano28 savacano28 requested a review from johanah29 February 20, 2025 11:08
@savacano28 savacano28 merged commit 8d2ab30 into release/current Feb 20, 2025
6 checks passed
@savacano28 savacano28 deleted the issue/1860-ui-agents-expectations branch February 20, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants