Add orderID to spend POST

[cpacia]

When calling POST /ob/orderspend to pay for an order, the client should set the orderID field to the orderID.

This is needed for ethereum (but should be done for all coins regardless).

Dependent on OpenBazaar/openbazaar-go#1319

[rmisio]

We should probably wait until this is resolved, since this should probably happen on specific orderId field instead of on memo:

OpenBazaar/openbazaar-go#1319

[placer14]

Updated description to show dependency.

[placer14]

@rmisio Would you mind always passing in order ID into the orderID arg regardless of the coin? (Of course, this is assuming it is for an order, other wallet spends do not require the field. Unfortunately, the server can do no validation of an invalid call because the server can't anticipate the intent of the call (whether for order or non-order spends). This makes the API a little overloaded. We might want to make a separate order-dependent spend one day?

[rmisio]

Would you mind always passing in order ID into the orderID arg regardless of the coin? (Of course, this is assuming it is for an order, other wallet spends do not require the field.

No, I don't think that's a problem.

But since it sounds like we're getting seperate APIs, I guess you'll know the intent. We'll definitely pass in the orderId where the server requires it, which I assume is at least ETH.

[placer14]

Yeah, we'll be able to protect the request with the right expectations now. Thanks! (Updated the description with the correct endpoint.)

[placer14]

And here's an endpoint spec: https://api.openbazaar.org/#64413188-0b5f-46d0-99fb-2bb3d89519e2

[jjeffryes]

Closed in #1634