This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Only Translate Known Conditions #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmisio
suggested changes
Aug 9, 2019
| </div> | ||
| <% } else if (ob.metadata.contractType === 'PHYSICAL_GOOD') { %> | ||
| <div> | ||
| <%= ob.polyT('listingDetail.condition', { condition: `<b>${ob.polyT(`conditionTypes.${ob.item.condition.toUpperCase()}`)}</b>` }) %> |
Contributor
There was a problem hiding this comment.
This could be done natively using the polyglot function by passing in a _ option, e.g:
<%= ob.polyT('listingDetail.condition', { condition: `<b>${ob.polyT(`conditionTypes.${ob.item.condition.toUpperCase()}`, { _: ob.item.condition })}</b>` }) %>
Contributor
Author
There was a problem hiding this comment.
Thanks! I completely forgot about the fallback parameter.
rmisio
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the listing details view so the condition is translated in the render function, and unknown conditions are not translated. That allows it to handle listings with conditions that don't match our expected list. I think it's better for users to see the value directly from the data vs. "conditionTypes.SOMETHINGINCAPS".
Closes #1785