This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Refactor data sharing #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The STORE message sends a request to store data to the remote peer. The message contains a list of Cids the requesting peer wants to store. The remote peer responds with a list of Cids he needs. Finally the BLOCK message sends individual blocks to the peer for storage.
…nfigured to do so
Member
|
This has a potential complaint from DUO on deprecating this feature. I'm not sure how Mubiz or others feel either, but we should pause to get feedback. @JustinDrake this is a concern right? |
Contributor
|
In the context of an OpenBazaar client running in the browser, Duo has built infrastructure to cache offline messages. Right now we are assuming that the Duo gateway will be notified of offline message pointers. I want to confirm that the offline pointers will still be broadcasted to the gateways. |
Member
Author
|
Pointers are pushed using the DHT putProvider call instead of http. But, yes, they are still sent. |
The put and get provider functions in the DHT are exported and the IPFS pointer package is refactored to use those methods. All other areas where it was calling the DHT directly can use the pointer package.
ghost
approved these changes
Oct 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.