Skip to content

Audit fixes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Audit fixes #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dda45f4
Removing dead code from transferFunds function
sameepsi Nov 19, 2018
d11fdd9
Removing scriptHash field from Transaction struct
sameepsi Nov 19, 2018
3d0ce4d
Converting all implicit return statements to explicit return statements
sameepsi Nov 19, 2018
1414e5c
Improved revert error message in verifyTransaction function
sameepsi Nov 19, 2018
f0f7fef
Improved docstring in execute method
sameepsi Nov 19, 2018
5afe7a8
Improved error message in inFundedState modifier
sameepsi Nov 19, 2018
e93554b
Improved coding styles
sameepsi Nov 19, 2018
c5262e8
Improved code comments
sameepsi Nov 19, 2018
3029ab3
indexing the scriptHash argument in all events
sameepsi Nov 19, 2018
556f2e0
Removed unnecessary _value variable declaration from addTokensToTrans…
sameepsi Nov 19, 2018
93f5405
Added _ before each private and internal method and declared partyVsT…
sameepsi Nov 19, 2018
3249572
Changed this to address(this) to improve code readability
sameepsi Nov 19, 2018
941ebe7
Breaking complex require statements into multiple require statements
sameepsi Nov 19, 2018
253e970
Parameter ordering in docstring changed to match function definition …
sameepsi Nov 19, 2018
e0c7ca4
Update contract docstring and added specifications link
sameepsi Nov 19, 2018
d505177
Update Escrow test case comments
sameepsi Nov 19, 2018
452a206
lastModified parameter of transaction will not be updated when funds/…
sameepsi Nov 19, 2018
fe8c7b8
In addTokensToTransaction using msg.sender instead of buyer, both are…
sameepsi Nov 19, 2018
68d36ed
Update test cases comments
sameepsi Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18,793 changes: 9,358 additions & 9,435 deletions build/contracts/Escrow_v1_0.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading