-
Notifications
You must be signed in to change notification settings - Fork 2
Add Volume Control #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Volume Control #114
Conversation
…usic of the main menu keeps playing
- also exit the whole application if pressing esc in the min menu
- add volume control to it
… in the main menu
- use that slider in the settings menu for the volume - add left and rightCrossPlatformActions - disable the volume changing via +/- in the settings menu (by exiting, if a scene handled an event, and not continuing)
- use that, to detect if the settings menu is open on top of the ingame menu, than render it differently
2940f33 to
0a6dba8
Compare
6e96106 to
68ace7c
Compare
68ace7c to
98364c3
Compare
…e might have changed - set volume in music manager constructor, so that it silences the volume of SDL_Mix (not only internally) , when it starts with the silent flag
- this fixes a bug, where "E" was caught twice, opening the settings and holding a piece
…support per scene "bound" keys - use another key for opening the settings (P)
Cpp-Linter Report
|
This adds a Settings Menu and a rudimentary Slider to control the volume
It also adds some more keyboard shortcuts, notably:
This also fixes some uncaught logic bugs in the music manager with the fading in and out logic
Some screenshots:

