Fix linting errors; Update linting

Author: OpenByteDev

package.json

@@ -14,6 +14,7 @@
         "publish": "lerna publish",
         "ci-test": "lerna run ci-test",
         "lint-fix": "lerna run lint-fix",
+        "lint": "lerna run lint-fix",
         "build": "lerna run build",
         "gen-doc": "lerna run gen-doc",
         "test": "lerna run test",

packages/source-scraper-dom-runner/lib/DomRunner.ts

@@ -1,4 +1,4 @@
-import { IRunnerArgs, IRunnerOptions, Runner, IRunner } from 'source-scraper-core';
+import { IRunner, IRunnerArgs, IRunnerOptions, Runner } from 'source-scraper-core';
 
 import { DOMWindow, FromUrlOptions, JSDOM } from 'jsdom';
 

packages/source-scraper-dom-runner/test/tslint.json

@@ -5,8 +5,7 @@
     "jsRules": {},
     "rules": {
         "no-implicit-dependencies": false,
-        "no-unused-expression": false,
-        "max-line-length": [true, 140]
+        "no-unused-expression": false
     },
     "rulesDirectory": []
 }

packages/source-scraper-flowplayer-runner/lib/FlowplayerRunner.ts

@@ -1,6 +1,6 @@
-import { IRunnerArgs, IRunner, Runner } from 'source-scraper-core';
+import { IRunner, IRunnerArgs, Runner } from 'source-scraper-core';
 import {
-    IPuppeteerRunnerArgs, IPuppeteerRunnerOptions, IPuppeteerRunner, PuppeteerRunner
+    IPuppeteerRunner, IPuppeteerRunnerArgs, IPuppeteerRunnerOptions, PuppeteerRunner
 } from 'source-scraper-puppeteer-runner';
 
 import {J SHandle } from 'puppeteer';
@@ -58,7 +58,7 @@ export interface IFlowplayerRunnerArgs extends IRunnerArgs<IFlowplayerRunnerOpti
 export interface IFlowplayerRunner<T> extends IRunner<T, IFlowplayerRunnerOptions, IFlowplayerRunnerArgs> { }
 
 export class FlowplayerRunner<T> extends Runner<T, IFlowplayerRunnerOptions, IFlowplayerRunnerArgs>
-    implements IPuppeteerRunner<T>{
+    implements IPuppeteerRunner<T> {
     public defaultOptions: IFlowplayerRunnerOptions = {};
 
     protected async exec(

packages/source-scraper-flowplayer-runner/lib/SimpleFlowplayerScraper.ts

@@ -18,7 +18,8 @@ export class SimpleFlowplayerScraper
     public name: string = 'flowplayer';
     public domains: string[] = [];
     public urlPattern: RegExp = /.*/i;
-    public runner: FlowplayerRunner<ISimpleFlowplayerScraperSourceData> = new FlowplayerRunner<ISimpleFlowplayerScraperSourceData>();
+    public runner: FlowplayerRunner<ISimpleFlowplayerScraperSourceData> =
+        new FlowplayerRunner<ISimpleFlowplayerScraperSourceData>();
     public defaultOptions: ISimpleFlowplayerScraperOptions = {};
 
     protected async execWithArgs({ sources }: IFlowplayerRunnerArgs): Promise<ISimpleFlowplayerScraperSourceData> {

packages/source-scraper-flowplayer-runner/package.json

@@ -11,6 +11,7 @@
     },
     "dependencies": {
         "source-scraper-core": "^1.0.0",
+        "source-scraper-puppeteer-runner": "1.0.0",
         "puppeteer": "^1.7.0"
     },
     "devDependencies": {

packages/source-scraper-flowplayer-runner/tslint.json

@@ -1,7 +1,7 @@
 {
     "extends": [
         "tslint:latest"
-        "tslint-eslint-rules"
+        // "tslint-eslint-rules"
     ],
     "jsRules": {},
     "rules": {

packages/source-scraper-html-runner/test/tslint.json

@@ -5,8 +5,7 @@
     "jsRules": {},
     "rules": {
         "no-implicit-dependencies": false,
-        "no-unused-expression": false,
-        "max-line-length": [true, 140]
+        "no-unused-expression": false
     },
     "rulesDirectory": []
 }

packages/source-scraper-jwplayer-runner/lib/JWPlayerRunner.ts

@@ -121,14 +121,17 @@ export interface IJWPlayerRunnerArgs extends IPuppeteerRunnerArgs, IRunnerArgs<I
     poster: string;
 }
 
-export interface IJWPlayerRunner<T> extends IRunner<T, IIJWPlayerRunnerOptions, IIJWPlayerRunnerArgs> { extends Runner<T, IJWPlayerRunnerOptions, IJWPlayerRunnerArgs> {
+export interface IJWPlayerRunner<T> extends IRunner<T, IJWPlayerRunnerOptions, IJWPlayerRunnerArgs> { }
+
+export class JWPlayerRunner<T> extends Runner<T, IJWPlayerRunnerOptions, IJWPlayerRunnerArgs>
+    implements IJWPlayerRunner<T> {
     public defaultOptions: IJWPlayerRunnerOptions = {};
 
     protected async exec(
         url: string,
         scraper: (args: IJWPlayerRunnerArgs) => Promise<T>,
         options: IJWPlayerRunnerOptions): Promise<T> {
-        return new PuppeteerRunner().run(url, async (args: IPuppeteerRunnerArgs) => {
+        return new PuppeteerRunner().run(url, async (...args) => {
             const { page } = args;
             const jwplayer = await page.evaluateHandle('jwplayer()');
             const config = await page.evaluate(player => player.getConfig(), jwplayer);

packages/source-scraper-jwplayer-runner/test/tslint.json

@@ -5,8 +5,7 @@
     "jsRules": {},
     "rules": {
         "no-implicit-dependencies": false,
-        "no-unused-expression": false,
-        "max-line-length": [true, 140]
+        "no-unused-expression": false
     },
     "rulesDirectory": []
 }