Conversation
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 238 238
Lines 18525 18525
=======================================
Hits 14424 14424
Misses 4101 4101 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jmthomas
approved these changes
Aug 3, 2022
Member
jmthomas
left a comment
jmthomas
left a comment
There was a problem hiding this comment.
I assume the ‘:z’ doesn’t matter for other distros? What exactly does this do? Is there documentation you can link to?
Member
Author
|
The SELinux volume labels are discussed here: |
Member
Author
|
I've tested on Mac and it still works correctly. I don't expect any problems on Windows Docker Desktop because it also runs on a linux VM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Rootless podman for versions 5.0.5+ (and probably any linux with SELinux)