Skip to content

Check for plugin mods on upgrade and delete#42

Merged
jmthomas merged 5 commits intomasterfrom
upgrade_plugins
Aug 4, 2022
Merged

Check for plugin mods on upgrade and delete#42
jmthomas merged 5 commits intomasterfrom
upgrade_plugins

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Aug 3, 2022

No description provided.

@jmthomas jmthomas requested a review from ryanmelt August 3, 2022 16:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #42 (010f67f) into master (56b6efa) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 010f67f differs from pull request most recent head 8c13775. Consider uploading reports for the commit 8c13775 to get more accurate results

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   77.86%   77.78%   -0.08%     
==========================================
  Files         238      238              
  Lines       18525    18548      +23     
==========================================
+ Hits        14424    14428       +4     
- Misses       4101     4120      +19     
Impacted Files Coverage Δ
lib/openc3/models/target_model.rb 71.69% <0.00%> (-3.24%) ⬇️
config/routes.rb 100.00% <0.00%> (ø)
lib/openc3/models/process_status_model.rb 56.52% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:data-test="dataTestOk"
@click="ok"
>{{ params.okText }}</v-btn
>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material design says to have the primary action button on the right. We should eventually check all the other dialogs for consistency.

@jmthomas jmthomas merged commit 89eef3d into master Aug 4, 2022
@jmthomas jmthomas deleted the upgrade_plugins branch August 4, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants