Skip to content

Conversation

@aheil-lanl
Copy link
Contributor

@aheil-lanl aheil-lanl commented Nov 14, 2025

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

This pull request stops --file from defaulting to inventory.yaml across all subcommands, and adds appropriate errors when --file is not defined.

I am targeting a confusing error message in the firmware subcommand, where if neither --file nor --hosts is defined the tool attempts to read inventory.yaml and fails with a confusing message if that file does not exist.

Type of Change

  • Bug fix
  • New feature
  • Breaking change -- would break any workflows that expect file to default.
  • Documentation update

For more info, see Contributing Guidelines.

Signed-off-by: Almond Heil <aheil@lanl.gov>
@alexlovelltroy alexlovelltroy merged commit 2006c1d into OpenCHAMI:main Nov 14, 2025
1 check passed
@aheil-lanl aheil-lanl deleted the no_default_file branch November 14, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants