Skip to content

Conversation

@jekyc
Copy link
Contributor

@jekyc jekyc commented Jul 12, 2019

This moves the STIX "Custom Properties" (x_opencti_*) and internal "Observable Types" used by OpenCTI to a separate file so it is easier to identify the values used.

These classes can then be used by the connectors to ensure that the proper values are used.

The properties have been attempted commented/documented, but it would be nice with a better explanation of their uses and impact on OpenCTI (and also if they are required - such as x_opencti_observable_type and x_opencti_observable_value).

@SamuelHassine SamuelHassine self-requested a review July 20, 2019 22:18
Copy link
Member

@SamuelHassine SamuelHassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this very good PR. Useful and understandable for all future developers!

@SamuelHassine
Copy link
Member

@jekyc: could you please solve all conflicts in your PR? We will merge it in the next release.

@jekyc
Copy link
Contributor Author

jekyc commented Jul 21, 2019

Thanks for the pull. The conflicts should be resolved now.

@SamuelHassine SamuelHassine merged commit 16b28fc into OpenCTI-Platform:master Jul 21, 2019
aHenryJard pushed a commit to OpenCTI-Platform/opencti that referenced this pull request Nov 12, 2025
…m_properties_and_observable_types

Custom properties and observable types

(original commit: OpenCTI-Platform/client-python@16b28fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants