Skip to content

Fix/issue 2/clubs should not be able to use more than their points allowed #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/issue 2/clubs should not be able to use more than their points allowed #332

wants to merge 2 commits into from

Conversation

@elof-dev
Copy link

Summary

This pull request fixes Issue #2 — clubs could book more places than their available points allowed.

Context

The function purchasePlaces() in server.py did not validate whether a club had enough points before approving a booking.

Changes Made

  • server.py → added a condition in purchasePlaces() to prevent bookings exceeding the club’s available points
  • tests/test_book_point_with_enough_point.py → created to test purchasePlaces() behaviour with and wihtout enough points.
  • a new test file containing:

Testing

  • 2 tests pass successfully using pytest :
    • a test for booking within available points
    • a test for rejecting bookings exceeding available points

Linked Issue

Fix #2

@elof-dev
Fix issue #1 : correct showSummary and add Flask testing setup
2ba2fcf 
- Updated showSummary() in server.py to handle email validation and error messages
- Modified index.html to display flash messages correctly
- Created tests/ folder with conftest.py and test_show_summary.py for unit testing
- Added .flaskenv for local environment configuration
- Updated .gitignore to include .venv and exclude tests/ folder
- Updated requirements.txt to add pytest dependency
@elof-dev
Fix issue #2 : correct purchasePlaces() and add unit tests
8135241 
- Updated purchasePlaces() to check if the club has enough points before confirming a booking
- Added a new test file with 2 unit tests to verify point validation logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Clubs should not be able to use more than their points allowed

1 participant

@elof-dev